Backport #8259 to release/17.x #8270
Conversation
* Fix Vulkan SIMT mappings for GPU loop vars. Previous refactoring accidentally used the fully qualified var name rather than the categorized vulkan intrinsic name. * Avoid formatting the GPU kernel to a string for Vulkan (since it's binary SPIR-V needs to remain intact). --------- Co-authored-by: Derek Gerstmann <[email protected]> Co-authored-by: Steven Johnson <[email protected]>
|
Looks like there are Vulkan failures -- any clues? Are there more fixes I missed? |
|
Sorry! Yes, I saw this as well, but haven't been able to reproduce this on my Linux machine. Still investigating. |
|
We should also grab: #8130 |
…ocations (#8130) * Add conform API methods to block and region allocator classes Override conform requests for Vulkan memory allocator Cleanup memory requirement constraints for Vulkan Add conform test cases to block_allocator runtime test. * Clang format/tidy pas * Fix unsigned int comparisons * Clang format pass * Fix other unsigned int comparisons * Fix mismatched template types for max() * Fix whitespace for clang format --------- Co-authored-by: Derek Gerstmann <[email protected]>
|
PTAL -- lots of conflicts in the cherry pick so hopefully I did it right |
|
It looks like a few things from |
|
I inspected buildbot-4 and it only had v1.2 of the Vulkan SDK installed, but the build target we're using is generating code for SDK v1.3. I've upgraded that machine, but the other linux workers will likely need to get upgraded too. |
Tell me the process to upgrade and I'll handle it |
|
The packaging has changed since we originally setup the machines, and now everything is bundled under the vulkan-sdk for Ubuntu: https://vulkan.lunarg.com/doc/view/latest/linux/getting_started_ubuntu.html I just needed:
That should make |
Fix Vulkan SIMT mappings for GPU loop vars. Previous refactoring accidentally used the fully qualified var name rather than the categorized vulkan intrinsic name.
Avoid formatting the GPU kernel to a string for Vulkan (since it's binary SPIR-V needs to remain intact).